security(assail): classify the 4 audited false-positive panic-attack residuals#166
Merged
Merged
Conversation
…residuals
`panic-attack assail .` reports 9 weak points and 0 real vulnerabilities. The 5
PanicPath findings are auto-suppressed (test/bench code). The 4 production-script
findings are audited-sound false positives; record them in the user-classification
registry so re-scans are honestly, verifiably clean (registry lives apart from the
source, so a finding can't self-suppress — reviewable companion change).
- audits/assail-classifications.a2ml — classifies:
* scripts/{setup,install-on-phone,uninstall}.sh PathTraversal — the flagged path
is `/data/local/tmp/` (the canonical Android adb device-staging dir), NOT host
`/tmp`; `mktemp` would be incorrect for a device path.
* scripts/install-termux.sh HardcodedSecret — a public HuggingFace model URL + a
commented `# api_key = "sk-ant-..."` placeholder in a generated config template;
no secret committed.
- audits/audit-install-scripts.adoc — the reviewable rationale (§1 device paths,
§2 public URL / commented key template) cross-referenced by each entry.
Verified: re-ran the built panic-attack binary against neurophone — total
weak_points=9, suppressed=9, unsuppressed=0. Production code remains 0 unsafe /
0 panic-sites / 0 injection / 0 crypto-misuse.
Note (flagged, not fixed here): panic-attack emits "failed to read AI manifest:
extra tokens after manifest" on 0-AI-MANIFEST.a2ml — a minor a2ml-format nuance
to address in a follow-up.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0172RBMz3qYjb1ttzD2i7RNh
The estate `Validate A2ML manifests` gate (a2ml-validate-action) requires every .a2ml to carry an identity field (project/name/agent-id) and a version/ schema_version; panic-attack's registry format is bare S-expression, so the new audits/assail-classifications.a2ml failed with "Missing required identity field". Add top-level `project` + `schema_version` (matching a2ml-ecosystem conformance/valid/sectioned-manifest.a2ml) plus a `[metadata]` name/version. panic-attack's loader only reads `(classification …)` blocks and ignores everything else, so suppression is unaffected — re-verified: total=9, suppressed=9, unsuppressed=0. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0172RBMz3qYjb1ttzD2i7RNh
|
hyperpolymath
marked this pull request as ready for review
July 1, 2026 19:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Makes
panic-attack assailprovably clean for neurophone (answers "is it fullypanic-attacked and safely remediated?" — yes).
I built + ran the
panic-attacktool against neurophone: 9 weak points, 0 realvulnerabilities. 5
PanicPathfindings are already auto-suppressed (test/bench code).The 4 production-script findings are audited-sound false positives, now recorded in
the user-classification registry (which lives apart from the source, so a finding can't
self-suppress — a reviewable companion change per the panic-attack pattern):
audits/assail-classifications.a2ml:scripts/{setup,install-on-phone,uninstall}.shPathTraversal — the flagged pathis
/data/local/tmp/(the canonical Androidadbdevice-staging dir), not host/tmp.mktempwould be incorrect for a device path.scripts/install-termux.shHardcodedSecret — a public HuggingFace model URL# api_key = "sk-ant-..."placeholder in a generated config template.No secret is committed.
audits/audit-install-scripts.adoc— the reviewable rationale, cross-referenced per entry.Verified: re-ran the built binary →
total weak_points=9, suppressed=9, unsuppressed=0. Production code remains 0 unsafe / 0 panic-sites / 0 injection /0 crypto-misuse.
must-checkexit 0.Note (flagged, not fixed here)
panic-attackemitsfailed to read AI manifest: extra tokens after manifeston0-AI-MANIFEST.a2ml— a minor a2ml-format nuance for a follow-up (doesn't affect the scan).This is workstream A of the audit-remediation plan; doc-format fixes, RSR gaps, wikis,
android tests, and bot docs follow as separate PRs.
🤖 Generated with Claude Code
https://claude.ai/code/session_0172RBMz3qYjb1ttzD2i7RNh
Generated by Claude Code